No, you're not wrong at all :) That's exactly what you should be doing.
If you reward a dog with attention when it jumps, it will keep on jumping - because jumping works. And if you won't give attention until she sits, then she'll learn to sit for attention instead - because sitting...